fix(agent): surface par2/install/NFS failures instead of degrading silently
- usenet: Par2Verify/Repair return ErrPar2NotInstalled (was nil="verified"); pipeline surfaces it via Result.VerifyNote + WARNING — a download that shipped parity but couldn't be checked is delivered UNVERIFIED, not verified. - funnel: pin cloudflared version + verify a baked-in SHA-256 (was `latest` + ELF-magic only) — a malicious/broken upstream release isn't pulled silently. - stream: makeReadable verifies the file actually opens after chmod and warns clearly (NFS root_squash / SMB uid mapping) instead of a cryptic later EPERM. - WireGuard endpoint pin dropped from the debt list (reseller uses direct config, no pin).
This commit is contained in:
parent
27bee8cdf4
commit
3d51013935
9 changed files with 319 additions and 43 deletions
62
internal/funnel/install_test.go
Normal file
62
internal/funnel/install_test.go
Normal file
|
|
@ -0,0 +1,62 @@
|
|||
package funnel
|
||||
|
||||
import (
|
||||
"crypto/sha256"
|
||||
"encoding/hex"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// TestVerifySHA256 covers the integrity gate used on the auto-downloaded
|
||||
// cloudflared binary: it accepts the matching digest (case-insensitive) and
|
||||
// rejects a wrong one.
|
||||
func TestVerifySHA256(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "blob")
|
||||
content := []byte("cloudflared-bytes")
|
||||
if err := os.WriteFile(path, content, 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
sum := sha256.Sum256(content)
|
||||
good := hex.EncodeToString(sum[:])
|
||||
|
||||
if err := verifySHA256(path, good); err != nil {
|
||||
t.Errorf("verifySHA256(correct) = %v, want nil", err)
|
||||
}
|
||||
// Upper-case should still match.
|
||||
if err := verifySHA256(path, good[:60]+"ABCD"); err == nil {
|
||||
t.Error("verifySHA256(wrong) = nil, want mismatch error")
|
||||
}
|
||||
if err := verifySHA256(path, "deadbeef"); err == nil {
|
||||
t.Error("verifySHA256(short/wrong) = nil, want error")
|
||||
}
|
||||
}
|
||||
|
||||
// TestPinnedCloudflaredSHA256Complete guards the invariant that every linux arch
|
||||
// the downloader can select has a pinned 64-hex SHA-256, so a download never
|
||||
// reaches the verify step without an expected digest.
|
||||
func TestPinnedCloudflaredSHA256Complete(t *testing.T) {
|
||||
wantAssets := []string{
|
||||
"cloudflared-linux-amd64",
|
||||
"cloudflared-linux-arm64",
|
||||
"cloudflared-linux-armhf",
|
||||
"cloudflared-linux-386",
|
||||
}
|
||||
for _, a := range wantAssets {
|
||||
sum, ok := pinnedCloudflaredSHA256[a]
|
||||
if !ok {
|
||||
t.Errorf("missing pinned SHA-256 for %q", a)
|
||||
continue
|
||||
}
|
||||
if len(sum) != 64 {
|
||||
t.Errorf("%s: SHA-256 length = %d, want 64", a, len(sum))
|
||||
}
|
||||
if _, err := hex.DecodeString(sum); err != nil {
|
||||
t.Errorf("%s: SHA-256 not valid hex: %v", a, err)
|
||||
}
|
||||
}
|
||||
if pinnedCloudflaredVersion == "" {
|
||||
t.Error("pinnedCloudflaredVersion must be set")
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue